Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feat] add Graphics To Nonprofits Section + Patch Design #27

Merged
merged 7 commits into from
Jan 17, 2024
Merged

[feat] add Graphics To Nonprofits Section + Patch Design #27

merged 7 commits into from
Jan 17, 2024

Conversation

sampoder
Copy link
Collaborator

jinkang-0
jinkang-0 reviewed Jan 13, 2024
View reviewed changes
Copy link
Collaborator

@jinkang-0 jinkang-0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

everything looks great! Just a minor suggestion to take advantage of existing resources, but should be good to go after that's addressed

src/components/NonProfits.astro Outdated Show resolved Hide resolved
@sampoder sampoder requested a review from jinkang-0 January 13, 2024 22:44
jinkang-0
jinkang-0 reviewed Jan 14, 2024
View reviewed changes
Copy link
Collaborator

@jinkang-0 jinkang-0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the updates! one more update and it should be good to merge!! (sorry i know i said this before, but it looks like an overflow is occurring now for some reason)

public/shapes_sparkle_2.svg Outdated Show resolved Hide resolved
src/components/NonProfits.astro Outdated Show resolved Hide resolved
@jinkang-0
Copy link
Collaborator

These are minor changes so I'll add some updates to get us started on mobile ASAP

@jinkang-0 jinkang-0 changed the title Add Graphics To Nonprofits Section + Patch Design [feat] add Graphics To Nonprofits Section + Patch Design Jan 17, 2024
@allisonhongberkeley allisonhongberkeley merged commit 2756d8f into main Jan 17, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jinkang-0 jinkang-0 jinkang-0 left review comments

@allisonhongberkeley allisonhongberkeley allisonhongberkeley approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sampoder @jinkang-0 @allisonhongberkeley