[feat] create about section (Our Vision, The Mission) #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ccatherinetan
changed the title
ccatherinetan
changed the title
jinkang-0
reviewed
Jan 11, 2024
jinkang-0
reviewed
Jan 11, 2024
ccatherinetan
force-pushed
the
catherine/hfi-14-about-section
branch
from
cd00e4f to
4357938
Compare
jinkang-0
approved these changes
Jan 11, 2024
src/components/About.astro
Outdated
Comment on lines
45
to
53
| section { | ||
| display: flex; | ||
| flex-direction: column; | ||
| align-items: center; | ||
| text-align: center; | ||
| max-width: 58.625rem; | ||
| margin: 0 auto; | ||
| padding-top: 5rem; | ||
| } |
There was a problem hiding this comment.
For the purpose of the image carousel, it's best to make this width: 100% and contain the Vision and Mission sections inside a smaller child div.
There was a problem hiding this comment.
MMM this makes sense -- lemme do that
me-liu
pushed a commit
that referenced
this pull request
Jan 11, 2024
* create skeleton * change div to section * fill out Our Mission + Vision * add and use b * clean up / remove comments * check style (prettier) * remove b from global styles * create div for mission and vision
christophertorres1
pushed a commit
that referenced
this pull request
Jan 11, 2024
* create skeleton * change div to section * fill out Our Mission + Vision * add and use b * clean up / remove comments * check style (prettier) * remove b from global styles * create div for mission and vision
jinkang-0
added a commit
that referenced
this pull request
Jan 12, 2024
* feat(faq): adds faq section * [feat] add button component (#8) * add graphics, button * update global button style * update button styles * [feat] add nav bar (#9) * update navbar, h5 global style * update navbar height * [feat] add footer (#12) * add footer * remove edit to env.d.ts * use astro image for optimization * remove edit to env.d.ts * [feat] add hero section (#11) * update hero * update text styles, minor adjustment to hero layout * remove changes to env.d.ts * tell prettier to ignore env.d.ts * tell lint to ignore env.d.ts * update scroll behavior and padding * microscopic edits * add bouncing arrow * add padding-top to Contact section (#14) * fix(types): moves question type definition to FAQDropdown component * [feat] create about section (Our Vision, The Mission) (#13) * create skeleton * change div to section * fill out Our Mission + Vision * add and use b * clean up / remove comments * check style (prettier) * remove b from global styles * create div for mission and vision * feat(faq): adds faq section * fix(types): moves question type definition to FAQDropdown component * refactor: addresses review comments * refactor(faq): adjusts container width, updates keydown functionality --------- Co-authored-by: Jinkang Fang <[email protected]> Co-authored-by: ccatherinetan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's new?
adds b in _global.cssN.B.
Current:
Compare to Figma:
Linear Task
https://linear.app/hack-for-impact-2024/issue/HFI-14/about-section