Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[genre] Implement subgenre dropdowns for search #89

Merged
merged 12 commits into from
Apr 24, 2024
Merged

Conversation

kylezryr
Copy link
Contributor

@kylezryr kylezryr commented Apr 21, 2024

What's new in this PR

  • Added genre, tone, and topic dropdowns on the search screen
  • With no search in the search bar, pressing on a genre redirects the user to the corresponding genre page. Tone and topic selectors do nothing
  • With a search in the search bar, the user can select multiple tones, topics, or genres to filter search results
  • Added a clear filter button to reset all filters and display normal search results
  • No styling applied in this PR

Relevant Links

Notion Sprint Task

https://www.notion.so/calblueprint/genre-Implement-subgenre-dropdowns-for-search-cc819b7e16f84b9f9866c474f8f11a2e

Online sources

https://www.npmjs.com/package/react-native-element-dropdown

Related PRs

  • Styling subgenre dropdowns

How to review

Next steps

  • Styling the dropdowns and the clear filter button, making sure they appear in the correct place

Tests Performed, Edge Cases

  • Selected genre still shows in the dropdown after navigating to the genre page and going back to the search page, and persists after closing the search results

Screenshots

subgenre.MP4

CC: @adityapawar1

@kylezryr kylezryr requested a review from adityapawar1 April 21, 2024 22:54
@kylezryr kylezryr marked this pull request as ready for review April 21, 2024 23:11
@adityapawar1 adityapawar1 merged commit c06877c into main Apr 24, 2024
1 check passed
@adityapawar1 adityapawar1 deleted the kyle/subgenre branch April 24, 2024 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants