Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug] Weird issues with keyboard in signup #85

Merged
merged 3 commits into from
Apr 19, 2024
Merged

Conversation

jjstnlee
Copy link
Contributor

What's new in this PR

Fixed issue where keyboard would push everything up and then down for Username and First Name. Changed it so that it doesn't move the screen anymore unless the input you are on is being covered.

Relevant Links

Notion Sprint Task

https://www.notion.so/calblueprint/bug-Weird-issues-with-keyboard-in-signup-889c22ed6e4648c2bc655765e12e40c2

Online sources

Related PRs

How to review

Check signup page.

Next steps

Tests Performed, Edge Cases

Screenshots

RPReplay_Final1713500203.mov

CC: @adityapawar1

@jjstnlee jjstnlee requested a review from adityapawar1 April 19, 2024 04:21
Copy link
Collaborator

@adityapawar1 adityapawar1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yay looks good!

@adityapawar1 adityapawar1 merged commit 85549e7 into main Apr 19, 2024
1 check passed
@adityapawar1 adityapawar1 deleted the justin/signup-bug branch April 19, 2024 05:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants