Refactor: remove Cypress #2535
Merged
Refactor: remove Cypress #2535
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
these tests as written are not providing any sort of critical test coverage that we need to keep around. we plan to use Playwright for this type of front-end testing, and there is no need to wait until we have written those to remove these Cypress tests.
|
Preview url: https://benefits-2535--cal-itp-previews.netlify.app |
github-actions
bot
added
the
documentation
Coverage report
This PR does not seem to contain any modification to coverable code. |
github-actions
bot
added
tests
thekaveman
approved these changes
Nov 25, 2024
Thanks, I can do that now! |
|
Removed |
Closed
Hopefully from |
|
Ah yes, I meant |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2534
This PR removes Cypress from our project.
The plan is to use Playwright for any automated front-end testing, and we will start with automating the smoke tests that are part of our release process (see #2504).
Eventually, we may add the type of automated front-end testing that these Cypress tests were meant to do, which was something more like front-end validation / regression / QA testing.
I went through all the Cypress tests we have, and none of them appear to be a critical test that we need to keep around while moving on to Playwright. Rather than waiting until we've replaced these tests with corresponding Playwright tests, I think we should just go ahead and remove Cypress wholesale. It's probably better anyways for us to revisit when exactly a front-end QA test is warranted.
Just for historical record purposes, here is a list of tickets that show our history with trying to use Cypress: