Use valid table HTML for PR description #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
javierjulio
force-pushed
the
html-output-update
branch
from
fa3279c to
891ec45
Compare
cakeinpanic
reviewed
Jun 21, 2024
|
oh, there are conflicts now, pls resolve them :) |
This also adds a test case as the buildPRDescription method didn't have any coverage.
This way when editing a PR description, this generated content doesn't take up that much space.
javierjulio
force-pushed
the
html-output-update
branch
from
f29d872 to
14cdca3
Compare
|
@cakeinpanic this is now ready, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the PR description output to use valid table HTML and adds a test case as the
buildPRDescriptionmethod didn't have any coverage. I'd like to do a future update to improve the layout of the table contents but wanted to get this in first.