Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(replication): support images list replication #63

Open
wants to merge 2 commits into
base: release-1.8.0-wd
Choose a base branch
from
Open

feat(replication): support images list replication #63

wants to merge 2 commits into from

Conversation

zhujian7
Copy link

支持镜像列表同步

Cherrypick: #62

cc @hyy0322

@caicloud-bot
Copy link

@zhujian7: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the caicloud/tools repository.

@caicloud-bot caicloud-bot added do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. caicloud-cla: yes Indicates the PR's author has not signed the Caicloud CLA. labels Nov 24, 2020
@caicloud-bot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: supereagle

Assign the PR to them by writing /assign @supereagle in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

hyy0322
hyy0322 reviewed Nov 25, 2020
View reviewed changes
src/core/api/replication_execution.go
resources = append(resources, recource)
}

trigger := r.GetString("trigger", string(model.TriggerTypeManual))
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need to get trigger.

@zhujian7
Copy link
Author

/release-note-none

@caicloud-bot caicloud-bot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Nov 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hyy0322 hyy0322 hyy0322 left review comments

Assignees
No one assigned
Labels
caicloud-cla: yes Indicates the PR's author has not signed the Caicloud CLA. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zhujian7 @caicloud-bot @hyy0322