More generic error handling #204
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vhdirk
force-pushed
the
errors
branch
2 times, most recently
from
4946380 to
c9a3ac9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So, I'm working towards revisiting #175 so it could be merged. I'm splitting that up to make the whole process more manageable.
Since in #175 I'm trying to use as little polling as possible, I wanted to have better error handling. Waiting for an edge on a pin is wholly different from SPI communication. In the current code base, errors originating from, for instance, pulling the reset pin low are completely ignored.
I'd love to hear your opinion!