-
Notifications
You must be signed in to change notification settings - Fork 138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for epd12in48b_v2 #174
Conversation
I have the same device and same ESP32 and this worked for me. But mine is v1 because it did not come with a v2 sticker as the documentation says. This device has a slightly different startup procedure in the upstream code as seen here, though I'm not sure if it makes a difference. The only thing it seems to change is that the v2 startup flashes a lot more compared to v1 on mine. I did a quick change to this to implement v1 as well, though I don't know if this is how you would want to implement it. See this diff.patch |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your work!
I would prefer to have the example in your own, separate repository, which we can link to from this repository.
The rest looks good to me.
It would be great to support v1 as well. I think we could solve this with feature-gating without much code duplication. |
aeb3c0c
to
18f9793
Compare
Improve Documentation slightly
Change text code block to markdown instead of rust
Here's a first draft of my driver for 12.48" module. Does this look like something you'd be willing to integrate?