Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#11285 Modified config service API response to return correct data type #11323

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

arishta
Copy link

@arishta arishta commented Jan 3, 2025

Fixed issue: #11285

Describe changes proposed in this pull request:

  • The server config API : config_service returns all values as strings, including boolean values (like 'true' or 'false'). These values had to be parsed in the frontend. This PR modifies the response to return the correct data type.

For more context, please refer the previously closed PR for this issue.
cBioPortal/cbioportal-frontend#5070

Testing

  • Manually tested

As can be seen in the screenshot, the response includes the values as boolean (true/false) and not strings ("true"/"false").
Screenshot 2025-01-03 at 11 20 54 PM

Checks

Any screenshots or GIFs?

If this is a new visual feature please add a before/after screenshot or gif
here with e.g. Giphy CAPTURE or Peek

Notify reviewers

Read our Pull request merging
policy
. It can help to figure out who worked on the
file before you. Please use git blame <filename> to determine that
and notify them either through slack or by assigning them as a reviewer on the PR

@arishta
Copy link
Author

arishta commented Jan 3, 2025

Hi @inodb @alisman
Please review this fix for the issue: #11285.

@arishta arishta force-pushed the 11285-server-config-properties branch from af4889c to 79c1183 Compare January 4, 2025 02:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant