Change file and links name to resource displayName #5061
Conversation
✅ Deploy Preview for cbioportalfrontend ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
| linkText={ | ||
| this.store.resourceDefinitions | ||
| .result?.length == 1 | ||
| ? this.store.resourceDefinitions | ||
| .result[0].displayName | ||
| : RESOURCES_TAB_NAME | ||
| } |
There was a problem hiding this comment.
how does this work when there is only a resource definition for a study resource (e.g. rather than a sample or patient resource)? I guess, technically, it might show up as two tabs with the same name? Prolly ok to not handle this case but just curious
There was a problem hiding this comment.
ah i see. it's if the length is one.
There was a problem hiding this comment.
@hweej i think this will have behavior where tab will have text RESOURCE_TAB_NAME while the resource definitions are loading and then the name will switch. We should probably just the tab until it finishes loading. see hide propery on other tabs in this collection
There was a problem hiding this comment.
@alisman it looks like the hide property already waits for the definition: https://github.com/hweej/cbioportal-frontend/blob/ae9281eff50a9ff7241393de154970cf8c32b3c5/src/pages/studyView/StudyViewPage.tsx#L380-L386. I think that's what you mean right?
There was a problem hiding this comment.
Let's maybe merge this and come back to the hide functionality if it is indeed an issue
inodb
changed the title
Adds a condition to the link text where if all resources are of the same type, then rename the Files & Links tab to the resourceDefinition displayName