Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass through all EventClock params to shim #62

Merged
merged 2 commits into from
Oct 18, 2024
Merged

Pass through all EventClock params to shim #62

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
769a935
Pass through all `EventClock` params to shim
davidselassie Oct 11, 2024
a65944f
Adds a changelog
davidselassie Oct 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
# Bytewax Interval Changelog

All notable changes to this project will be documented in this file.

## Latest

__Add any extra change notes here and we'll put them in the release
notes on GitHub when we make a new release.__

- Fixes an issue with interval operators not respecting
`EventClock.now_getter` and `EventClock.to_system_utc` if they were
set.

## v0.1.0

Initial version.
2 changes: 2 additions & 0 deletions src/bytewax/interval/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -750,6 +750,8 @@ def shim_getter(i_v: Tuple[str, V]) -> datetime:
clock = EventClock(
ts_getter=shim_getter,
wait_for_system_duration=clock.wait_for_system_duration,
now_getter=clock.now_getter,
to_system_utc=clock.to_system_utc,
)

logic_class: Callable[
Expand Down