Anil/price feed tests #4
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…aults receive quotes Refs: Agoric#9928 Refs: Agoric/BytePitchPartnerEng#25 fix: lint fixes Refs: Agoric/BytePitchPartnerEng#25
anilhelvaci
force-pushed
the
anil/price-feed-tests
branch
from
baff9e6 to
c3b30ff
Compare
…js` to the changes `priceFeed.test.js` introduces Refs: Agoric/BytePitchPartnerEng#25 Refs: Agoric#9928 fix: clear unused code fix: prettier fix
anilhelvaci
force-pushed
the
anil/price-feed-tests
branch
from
c3b30ff to
cbee1a5
Compare
|
Please see Agoric#9595. I measured activity on all vats. Those graphs only show the active contracts, which doesn't include the abandoned priceFeed and scaledPriceAuthority vats. The load I was measuring assumed oracles fed price data to the priceFeeds to be found in agoricName, using the new invitations provided when the new scaledPriceAuthorities started up. Can you explain what this adds to that analysis? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: https://github.com/Agoric/BytePitchPartnerEng/issues/25
refs: Agoric#9928
Description
Agoric#10074 replaced existing
priceFeedsandscaledPriceAuthoritieswith new ones that should be more efficient in terms of space usage. However, terminating those old vats is a problem that hasn't been solved as described in Agoric#9483. So it is important to make sure those old vats are actually quiescent. We also need to make sure we are able to produce quotes successfully. In this PR we are addressing these concerns.Security Considerations
None.
Scaling Considerations
None.
Documentation Considerations
None.
Testing Considerations
Regarding observing vat details there are 2 assumptions we are relying on;
Agoric#9928 talks about making sure auctions receive quotes. That is no tested here due to the high fidelity of testing auctions. The auctions features are tested Agoric#10229 so I believe there will be comprehensive coverage when it is merged.
Upgrade Considerations
None.
Help from reviewers
Agoric#10074 introduced new price feeds to the system. However,
f:replace-price-feedsdoes not activate oracles for future layers of the build. Meaning, proposals running afterf:replace-price-feedswill not have oracles that received invitationMakers for new price feeds and there will not be quotes published by new price feeds. There are conflicting work to fix this issue, see;usephase off:replace-price-feedsAgoric/agoric-sdk#10296usephase off:replace-price-feedsAgoric/agoric-sdk#10296 (review)As a work around I've implemented an
initmethod that runs duringtest.beforeto set the stage before we start testing new price feeds. I could use some guidance from you guys how to proceed from here. One option I can think of is to haveinitwork conditionally.