Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: pending messages should only be cleared if there is a discrepancy between what we requested regarding the session and what the server responds with #923

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

amokfa
Copy link
Contributor

@amokfa amokfa commented Oct 29, 2024

Type of change

Make sure session cleaning on the client side happens as per the mqtt specification. (Section 3.1.2.4 of mqtt 3.1.1 specification)

Checklist:

  • Formatted with cargo fmt
  • Make an entry to CHANGELOG.md if it's relevant to the users of the library. If it's not relevant mention why.

…y between what we requested regarding the session and what the server responds with
* changelog
@amokfa amokfa requested review from tekjar and swanandx October 29, 2024 04:57
@coveralls
Copy link

Pull Request Test Coverage Report for Build 11567567609

Details

  • 3 of 11 (27.27%) changed or added relevant lines in 2 files are covered.
  • 113 unchanged lines in 6 files lost coverage.
  • Overall coverage decreased (-0.04%) to 36.066%

Changes Missing Coverage Covered Lines Changed/Added Lines %
rumqttc/src/v5/state.rs 0 8 0.0%
Files with Coverage Reduction New Missed Lines %
rumqttc/src/v5/state.rs 4 67.09%
rumqttc/src/eventloop.rs 5 85.03%
rumqttd/src/link/timer.rs 8 0.0%
rumqttd/src/link/remote.rs 25 46.03%
rumqttc/src/v5/eventloop.rs 28 7.51%
rumqttd/src/link/bridge.rs 43 0.0%
Totals Coverage Status
Change from base Build 10511632669: -0.04%
Covered Lines: 5987
Relevant Lines: 16600

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants