Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Multiple Namespace & Abstract Notifier #16

Open
wants to merge 7 commits into
base: palanca-toggleable
Choose a base branch
from

Conversation

idhame
Copy link

@idhame idhame commented Jun 12, 2019

No description provided.

@idhame idhame changed the title Support Multiple Namespace Support Multiple Namespace & Abstract Notifier Jun 12, 2019
@codecov-io
Copy link

codecov-io commented Jun 12, 2019

Codecov Report

Merging #16 into palanca-toggleable will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@                Coverage Diff                @@
##           palanca-toggleable    #16   +/-   ##
=================================================
  Coverage                 100%   100%           
=================================================
  Files                      10     11    +1     
  Lines                     226    228    +2     
=================================================
+ Hits                      226    228    +2
Impacted Files Coverage Δ
lib/toggleable/storage/memory_store.rb 100% <100%> (ø) ⬆️
lib/toggleable/feature_toggler.rb 100% <100%> (ø) ⬆️
lib/toggleable.rb 100% <100%> (ø) ⬆️
lib/toggleable/configuration.rb 100% <100%> (ø) ⬆️
lib/toggleable/notifier_abstract.rb 100% <100%> (ø)
lib/toggleable/base.rb 100% <100%> (ø) ⬆️
lib/toggleable/logger_abstract.rb 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 694d2fe...f188735. Read the comment docs.

@idhame idhame requested a review from budipang June 12, 2019 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants