Remove native ios event modal tool bar #569
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #568
I believe that in this scenario where we call the iOS event modal, we don’t need the toolbar and can set it to be hidden. This adjustment should fix the issue of abnormal transparent padding at the bottom of the modal.
In addition, I also fixed a missing eventId parameter in example/../calendar_event.dart. The EventAttendeePage component was not receiving the eventId, which was preventing it from demonstrating the functionality of opening the iOS event modal.
The following screenshot shows the result after the fix: calling
showiOSEventModalin the EventAttendeePage example now displays the bottom edge correctly.