Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added event color field for Android #516

Open
wants to merge 11 commits into
base: develop
Choose a base branch
from
Open

Added event color field for Android #516

wants to merge 11 commits into from

Conversation

NaoKreuzeder
Copy link

Now able to get the event-color from the Event object

@Peng1104
Copy link

Peng1104 commented Mar 3, 2024

Feature request from: #517

IVLIVS-III
IVLIVS-III requested changes Apr 10, 2024
View reviewed changes
Copy link
Contributor

@IVLIVS-III IVLIVS-III left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove the code thats commented out, e.g. // name ….

Also, is there a similar concept of event color on iOS? If yes, then we should implement the feature on both platforms.

@chris-wolf chris-wolf mentioned this pull request Jul 14, 2024
Merged
@chris-wolf
Copy link

Created a new PR: #546 which includes the loading logic of this PR and adds updateEventColor functionality

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IVLIVS-III IVLIVS-III IVLIVS-III requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@NaoKreuzeder @Peng1104 @chris-wolf @IVLIVS-III