Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding interface for setting kernel filter #9

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

LehmRob
Copy link

@LehmRob LehmRob commented Apr 30, 2019

Adding a function for the Bus object which makes it possible to activate a kernel side filtering for CAN frames. The function takes an array of unix.CanFilter objects.

The kernel side filtering reduces the load for the application if only a subset of received CAN frames are interesting.

@LehmRob
Copy link
Author

LehmRob commented Jun 17, 2019

Any feedback? Please tell me if there is something wrong with the pull request.

@brutella
Copy link
Owner

brutella commented Sep 3, 2019

Thanks for the pull request.

Not sure why you removed parts of the readme.
You changed the module name to github.com/sitec-systems/can – but it should actually be github.com/brutella/can.

@LehmRob
Copy link
Author

LehmRob commented Sep 10, 2019

Oh sorry for that. That's my first pull request and I didn't know that further commits are landing here as well. I reverted the changes on the README. Again sorry for that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants