-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rearrange2 #2436
Rearrange2 #2436
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks great overall, but now that you have raised awareness to \tiny
... \Huge
having moved out of TeX.pool.ltxml in #2358, I worry they will quietly disappear in cases they used to work in before. Ideally, we would like to make them widely available to all .cls
cases in latexml that used to work in the past.
So at the least we should add them to OmniBus.cls.ltxml
?
But I also wonder if they wouldn't be a reasonable fit in the font-related block of LaTeX.pool.ltxml
itself for now, until the next evolution of .cls
support.
On a closer look, the bindings that don't use LoadClass, and are hence top-level class definitions, are:
- report.cls.ltxml, article.cls.ltxml, slides.cls.ltxml, standalone.cls.ltxml,book.cls.ltxml
And possibly some third-party definitions external to the LaTeXML repository, but we don't have full visibility there. I see standalone loads its raw variant which loads article, so that is OK.
So there is a remaining change of behavior only in the slides.cls.ltxml
case, for the in-repo bindings.
#====================================================================== | ||
DefPrimitiveI('\tiny', undef, undef, font => { size => 5 }); | ||
DefPrimitiveI('\scriptsize', undef, undef, font => { size => 7 }); | ||
DefPrimitiveI('\footnotesize', undef, undef, font => { size => 8 }); | ||
DefPrimitiveI('\small', undef, undef, font => { size => 9 }); | ||
DefPrimitiveI('\normalsize', undef, undef, font => { size => 10 }); | ||
DefPrimitiveI('\large', undef, undef, font => { size => 12 }); | ||
DefPrimitiveI('\Large', undef, undef, font => { size => 14.4 }); | ||
DefPrimitiveI('\LARGE', undef, undef, font => { size => 17.28 }); | ||
DefPrimitiveI('\huge', undef, undef, font => { size => 20.74 }); | ||
DefPrimitiveI('\Huge', undef, undef, font => { size => 29.8 }); | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I should flag that I plan to open a related issue: \tiny
, ..., \Huge
are responsible for changing \baselineskip
, and the fact that LaTeXML does not do that has very visible side effects with TikZ.
Good catch! |
This PR rearranges a bit of code to more appropriate modules; more consistent utilities and naming. Improves the tracing and debugging commands.