Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initial support for Vietnamese #2228

Merged
merged 2 commits into from
Oct 9, 2023
Merged

Initial support for Vietnamese #2228

merged 2 commits into from
Oct 9, 2023

Conversation

brucemiller
Copy link
Owner

This seems to supply at least nominal support for Vietnamese characters and accents.

Fixes #2052

@brucemiller brucemiller requested a review from dginev October 8, 2023 14:20
dginev
dginev approved these changes Oct 9, 2023
View reviewed changes
Copy link
Collaborator

@dginev dginev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@brucemiller
Copy link
Owner Author

I forgot to add that last bit (an Info when an encoding is unknown) which might help future debugging efforts.

@brucemiller brucemiller merged commit f9080ec into master Oct 9, 2023
26 checks passed
@brucemiller brucemiller deleted the vietnamese branch October 9, 2023 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dginev dginev dginev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

About Vietnamese and LaTeXML
2 participants
@brucemiller @dginev