Improved \color parsing and scaling for custom RGB directives #2223
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a Fatal error in ar5iv#388, as well as a subtle precision bug in color conversion.
I have added the offending examples to the
t/graphics/xcolor.tex
test, to avoid regressions.There were 3 conceptual changes here:
\color
sprintf
(0,0,1,0)
, resulting in(0,0,0.75,0)
. The issue is that if only then a conversion to the RGB model is performed, we lose the scaling information on all but the yellow axis (due to the zero components). If we instead first switch from CMYK to RGB and then scale down by 0.25, we get the exact right results as in the PDF.This PR feels complete to me, welcoming a review.