Mojave #97
Open
Mojave #97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not my code, credit to @pkovtuov #94 |
parera10
approved these changes
Sep 25, 2018
parera10
approved these changes
Sep 25, 2018
|
+1 |
6 tasks
nisimond
suggested changes
Nov 30, 2018
| $cmd = "clear && exec $cmd" unless $config->debug; | ||
| } | ||
| } | ||
| $cmd = "clear && exec $cmd" unless $config->debug; |
There was a problem hiding this comment.
This looks like an unrelated change, and appears as though it will break compatibility with fish shells.
Also, turns the comment into a lie.
|
This PR does work as advertised, although the two commits should be rebased/squished together, since the latter one un-does most of the changes in the former. |
|
Caveat: you need to set "System Preferences » Dock » Prefer tabs when opening documents" to "Manually" or this REALLY doesn't work anymore. |
|
I will try to take a look on this asap.
Saluts,
Guillem
… El 30 nov 2018, a las 18:45, Nicolas Simonds ***@***.***> escribió:
Caveat: you need to set "System Preferences » Dock » Prefer tabs when opening documents" to "Manually" or this REALLY doesn't work anymore.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub <#97 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ANrzAG9UUfiXYAYksM6q85bvOK3GPr3yks5u0W7MgaJpZM4W5OQA>.
|
|
Whoops. I posted these reviews from the wrong account. Not that it makes much of a difference. |
|
Hi, I've forked and merge them in my account:
Regards |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.