Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⛔ [DO NOT MERGE] ⛔ Fix partition grouping bug ⛔ #8785

Open
wants to merge 1 commit into
base: EchoCallset
Choose a base branch
from

Conversation

mcovarr
Copy link
Collaborator

@mcovarr mcovarr commented Apr 21, 2024

⛔ DO NOT MERGE this into the EchoCallset branch ⛔ just yet; it's probably better to address this bug in the current EchoCallset run by adding the two missing partitions to the last group and rerunning the last group only rather than rerunning all the groups with a larger group size.

Add in n_rounds - 1 to the group size expression to include all of the partitions in the set of groups, otherwise we omit the final n_parts % n_rounds partitions.

Concretely for AoU Echo with 145192 total partitions and 5 rounds:

>>> 145192 // 5
29038
>>> 29038 * 5
145190
>>> (145192 + 5 - 1) // 5
29039

gbggrant added a commit that referenced this pull request Jul 11, 2024
This fixes a bug in the partioning logic used in creating Hail VAT inputs.
gbggrant added a commit that referenced this pull request Jul 11, 2024
This fixes a bug in the partioning logic used in creating Hail VAT inputs.
@gbggrant
Copy link
Collaborator

FYI - I merged the same code (in a different PR) into EchoCallset branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants