⛔ [DO NOT MERGE] ⛔ Fix partition grouping bug ⛔ #8785
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
⛔ DO NOT MERGE this into the EchoCallset branch ⛔ just yet; it's probably better to address this bug in the current EchoCallset run by adding the two missing partitions to the last group and rerunning the last group only rather than rerunning all the groups with a larger group size.
Add in
n_rounds - 1
to the group size expression to include all of the partitions in the set of groups, otherwise we omit the finaln_parts % n_rounds
partitions.Concretely for AoU Echo with 145192 total partitions and 5 rounds: