Move project to python 3.8 #203
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Due to this we need to wait for |
|
There are a couple of separate issues here. One is python 3.8. Another is pytorch 2.0. For some reason, pytorch 2.0 seems to make a lot of tests fail. Some are related to this but there appear to be more. If I use |
|
Like this too |
This was referenced Aug 7, 2023
|
Hi @sjfleming thank you for your work on this project! Do you know what the status of this PR is? I would be very happy to see an update of the python version. As far as I can see, all of the blockers linked above have been resolved? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pytorch, among other packages, have moved away from python 3.7.
https://pytorch.org/blog/deprecation-cuda-python-support/
This means python 3.7 will not be workable moving forward, and we need to update
cellbenderto python 3.8 at minimum.