Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use netlink instead of Wireless Extensions #1879

Draft
wants to merge 18 commits into
base: main
Choose a base branch
from
Draft

Use netlink instead of Wireless Extensions #1879

wants to merge 18 commits into from

Conversation

Caellian
Copy link
Collaborator

@Caellian Caellian commented May 1, 2024 •
edited
Loading

This PR removes deprecated iwlib related code and replaces it with netlink library.

State

  • change/setup dependencies
    • update CI & Docker files
  • implement some basic code that can handle some of the existing stats
    • dispatch new requests when requests aren't in_flight already
  • simplify changes for future contributors
    • improve documentation
  • reduce diff

Testing

  • nl cache works
  • test commands
    • wireless_ap
    • wireless_bitrate
    • wireless_channel
    • wireless_essid
    • wireless_freq
    • wireless_link_qual
    • wireless_link_qual_max
    • wireless_mode
  • test default command values
  • ensure correct interface data is returned
  • ensure correct network info is returned
  • check delay between command issuing and finish callback to determine ideal handling (eager vs. lazy)
  • test what happens when conky only renders once

@Caellian
Start implementing netlink
c08970a 
Signed-off-by: Tin Švagelj <[email protected]>
@Caellian Caellian linked an issue May 1, 2024 that may be closed by this pull request
Migrate from libiw to libnl for wireless support #1001
Open
@github-actions github-actions bot added sources PR modifies project sources dependencies adds or removes dependencies, or suggests alternatives networking related to network information reporting labels May 1, 2024
@netlify Netlify
Copy link

netlify bot commented May 1, 2024 •
edited
Loading

✅ Deploy Preview for conkyweb canceled.

Name Link
🔨 Latest commit 46aeafb
🔍 Latest deploy log https://app.netlify.com/sites/conkyweb/deploys/67004ef22181d20008621958

@brndnmtthws brndnmtthws added the feature suggest addition of new functionality that isn't currently supported in any way label May 1, 2024
@Caellian
Add nl80211 header
bffecae 
Signed-off-by: Tin Švagelj <[email protected]>
@github-actions github-actions bot added 3rdparty suggests changes to 3rd party dependencies gh-actions suggest changing GitHub actions build system related to build system (CMake) and/or building process/assumptions labels May 1, 2024
@Caellian Caellian force-pushed the dev/netlink branch 10 times, most recently from a18dc06 to cd43e19 Compare May 1, 2024 16:00
Caellian added 2 commits May 1, 2024 20:57
@Caellian
Copy iw info implementation
f6d1bfe 
Update linux headers

Signed-off-by: Tin Švagelj <[email protected]>
@Caellian
Add genl dependency to CI
1e09e69 
Signed-off-by: Tin Švagelj <[email protected]>
Caellian added 3 commits May 1, 2024 23:14
@Caellian
Move new code to netlink-conky
aa3e9b7 
Replace define with a wrapper struct.

Signed-off-by: Tin Švagelj <[email protected]>
@Caellian
Improve API
23c9bb9 
Signed-off-by: Tin Švagelj <[email protected]>
@Caellian
Start implementing tasks
ebc3bdf 
Signed-off-by: Tin Švagelj <[email protected]>
Caellian
Caellian commented May 2, 2024
View reviewed changes
src/netlink-conky.h Outdated Show resolved Hide resolved
@github-actions github-actions bot added the os: macos related to MacOS label May 2, 2024
Caellian added 3 commits May 3, 2024 16:17
@Caellian
Cleanup nested_attributes helper
f47a502 
Signed-off-by: Tin Švagelj <[email protected]>
@Caellian
Fix runtime errors
a9b8ba7 
Signed-off-by: Tin Švagelj <[email protected]>
@Caellian
Get interface information to work
118e0f8 
Signed-off-by: Tin Švagelj <[email protected]>
@Caellian
Copy link
Collaborator Author

Caellian commented May 5, 2024 •
edited
Loading

Ok, got interface information to update, so this PR is ~70% done with regards to figuring stuff out:

image

@Caellian Caellian mentioned this pull request May 9, 2024
Closed
@Caellian Caellian mentioned this pull request Jul 15, 2024
Closed
@Caellian Caellian mentioned this pull request Oct 3, 2024
Open
@github-actions github-actions bot added the display: x11 related to X11 backend label Oct 4, 2024
@Caellian Caellian mentioned this pull request Oct 19, 2024
Closed
@Caellian Caellian linked an issue Dec 17, 2024 that may be closed by this pull request
[Bug]: ${addrs} now reports gateway's address instead of machine address. #1542
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
3rdparty suggests changes to 3rd party dependencies build system related to build system (CMake) and/or building process/assumptions dependencies adds or removes dependencies, or suggests alternatives display: x11 related to X11 backend feature suggest addition of new functionality that isn't currently supported in any way gh-actions suggest changing GitHub actions networking related to network information reporting os: macos related to MacOS sources PR modifies project sources
Projects
None yet
Milestone
No milestone
2 participants
@Caellian @brndnmtthws