Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding code to use pkg-config on linux and MacPorts #20

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

Elettronik
Copy link

Adding code to use pkg-config on linux and MacPorts, thanks to suggestion of @sodabrew.
This modification let gem find icu-i18n easier, and let track lib names.

Valentino Dell'Aica and others added 2 commits November 9, 2012 12:16
Signed-off-by: Valentino Dell'Aica <[email protected]>
Adding the code suggested by @sodabrew to find pkgconfig and icu-18n on MacPorts
@osbornebrook
Copy link

This allows the gem to install correctly for me with a macports-installed icu. Thanks @Elettronik.

@scunz
Copy link

scunz commented Jan 24, 2013

Any chance this can be merged to master? It fixes compilation at least for gentoo-linux based systems.

@rbq
Copy link

rbq commented Jan 26, 2013

I came here because git_statistics wouldn't install. Can't believe this code is sitting here unmerged for 5 months. :(

@pascalj
Copy link

pascalj commented Sep 25, 2013

Still no chance to merge this? It also fixes the installation on FreeBSD.

@isanosian
Copy link

Hey guys, any chance to get this merged? I'm using OSX and it fails to install the thing through MacPorts, so this code could be helpful. No chance to switch to HomeBrew so far, 'cause they're just doing much worse job than MacPorts team and lack many things I use.

@osbornebrook how do you install the gem with this code without having this PR merged?

@cooljeanius
Copy link

I would like to see this pull request merged sometime

@Elettronik
Copy link
Author

Seem that main author is trying to embed libraries in next version. I think this is a bad idea, since on linux systems ICU is already a standard library and is found on near all system. On the Mac OS side, I cannost say anything, since I don't own one, but using a library outside the control of a central package system, seem to be prone to cause future problem. Feel free to comment the above, any new point of view is welcome.

@cooljeanius
Copy link

Seem that main author is trying to embed libraries in next version.

Does this mean in #66? That still hasn't been merged yet, and has merge conflicts just like this one; I think that this PR's merge conflicts would probably be easier to resolve, since it's a simpler PR...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants