Remove chonky Lens and replace with microlens for smaller footprint. #996
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
June 10, 2024 13:17
Replace lens package with microlens packages and begin replacing the types. Re-exporting the matching types and updated some uses in Waiter and Error.
The use of throwingM and catching has been replaced with more basic throw/catch behaviour. Some formatting changes appear to have been applied as well.
Replace the IndexedTraversal on S3 traversal for microlens compat and the Int is not required for this traversal.
Closed
Flake lock file updates:
• Updated input 'flake-utils':
'github:numtide/flake-utils/4022d587cbbfd70fe950c1e2083a02621806a725?narHash=sha256-kAuep2h5ajznlPMD9rnQyffWG8EM/C73lejGofXvdM8%3D' (2023-12-04)
→ 'github:numtide/flake-utils/11707dc2f618dd54ca8739b309ec4fc024de578b?narHash=sha256-l0KFg5HjrsfsO/JpG%2Br7fRrqm12kzFHyUHqHCVpMMbI%3D' (2024-11-13)
• Updated input 'nixpkgs':
'github:nixos/nixpkgs/24fe8bb4f552ad3926274d29e083b79d84707da6?narHash=sha256-VwRTEKzK4wSSv64G%2Bg3RLF3t6yBHrhR2VK3kZ5UWisU%3D' (2024-01-07)
→ 'github:nixos/nixpkgs/dd51f52372a20a93c219e8216fe528a648ffcbf4?narHash=sha256-NQEO/nZWWGTGlkBWtCs/1iF1yl2lmQ1oY/8YZrumn3I%3D' (2024-12-08)
• Updated input 'pre-commit-hooks':
'github:cachix/pre-commit-hooks.nix/ea96f0c05924341c551a797aaba8126334c505d2?narHash=sha256-qq8NbkhRZF1vVYQFt1s8Mbgo8knj%2B83%2BQlL5LBnYGpI%3D' (2024-01-08)
→ 'github:cachix/pre-commit-hooks.nix/d8c02f0ffef0ef39f6063731fc539d8c71eb463a?narHash=sha256-%2BXTFXYlFJBxohhMGLDpYdEnhUNdxN8dyTA8WAd%2Blh2A%3D' (2024-12-08)
• Updated input 'pre-commit-hooks/flake-compat':
'github:edolstra/flake-compat/35bb57c0c8d8b62bbfd284272c928ceb64ddbde9?narHash=sha256-4gtG9iQuiKITOjNQQeQIpoIB6b16fm%2B504Ch3sNKLd8%3D' (2023-01-17)
→ 'github:edolstra/flake-compat/0f9255e01c2351cc7d116c072cb317785dd33b33?narHash=sha256-kvjfFW7WAETZlt09AgDn1MrtKzP7t90Vf7vypd3OL1U%3D' (2023-10-04)
• Removed input 'pre-commit-hooks/flake-utils'
• Updated input 'pre-commit-hooks/gitignore':
'github:hercules-ci/gitignore.nix/a20de23b925fd8264fd7fad6454652e142fd7f73?narHash=sha256-8DFJjXG8zqoONA1vXtgeKXy68KdJL5UaXR8NtVMUbx8%3D' (2022-08-14)
→ 'github:hercules-ci/gitignore.nix/637db329424fd7e46cf4185293b9cc8c88c95394?narHash=sha256-HG2cCnktfHsKV0s4XW83gU3F57gaTljL9KNSuG6bnQs%3D' (2024-02-28)
• Updated input 'pre-commit-hooks/nixpkgs-stable':
'github:NixOS/nixpkgs/c37ca420157f4abc31e26f436c1145f8951ff373?narHash=sha256-otaSUoFEMM%2BLjBI1XL/xGB5ao6IwnZOXc47qhIgJe8U%3D' (2023-06-03)
→ 'github:NixOS/nixpkgs/d063c1dd113c91ab27959ba540c0d9753409edf3?narHash=sha256-edm8WG19kWozJ/GqyYx2VjW99EdhjKwbY3ZwdlPAAlo%3D' (2024-11-04)
|
Thank you for this, I've got it a lot closer. There's just a couple more things to fix and then hopefully I can hit merge - I should get to them in the next few days, fingers crossed. |
Flake lock file updates:
• Updated input 'nixpkgs':
'github:nixos/nixpkgs/dd51f52372a20a93c219e8216fe528a648ffcbf4?narHash=sha256-NQEO/nZWWGTGlkBWtCs/1iF1yl2lmQ1oY/8YZrumn3I%3D' (2024-12-08)
→ 'github:nixos/nixpkgs/de1864217bfa9b5845f465e771e0ecb48b30e02d?narHash=sha256-Ucfnxq1rF/GjNP3kTL%2BuTfgdoE9a3fxDftSfeLIS8mA%3D' (2024-12-23)
• Updated input 'pre-commit-hooks':
'github:cachix/pre-commit-hooks.nix/d8c02f0ffef0ef39f6063731fc539d8c71eb463a?narHash=sha256-%2BXTFXYlFJBxohhMGLDpYdEnhUNdxN8dyTA8WAd%2Blh2A%3D' (2024-12-08)
→ 'github:cachix/pre-commit-hooks.nix/f0f0dc4920a903c3e08f5bdb9246bb572fcae498?narHash=sha256-ulZN7ps8nBV31SE%2BdwkDvKIzvN6hroRY8sYOT0w%2BE28%3D' (2024-12-21)
endgame
force-pushed
the
sc/change-lens-dep-to-microlens
branch
from
4e07029 to
567292c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the dependency on the mega
lenspackage and creates optics and friends using themicrolensset of packages. The use of Prisms does necessitate the inclusion ofprofunctorbut that is still a smaller price than all oflens.The work is somewhat incomplete as there are a few incompatibilities to iron out.