Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

close #1369 increase the php-fpm log limit to match AWS Cloudwatch #1824

Closed
wants to merge 1 commit into from

Conversation

allan-simon
Copy link
Contributor

So that the php-fpm process will not hang when reaching log_limit (it can still reach but it's muchhh harder, and reaching it would anyway cause an error with AWS Cloudwatch )

…atch

So that the php-fpm process will not hang when reaching log_limit (it can still reach but it's muchhh harder, and reaching it would anyway cause an error with  AWS Cloudwatch )
@mnapoli
Copy link
Member

mnapoli commented Jun 12, 2024

Hi, this branch is a very old (obsolete) branch:

Screen-001826

You might want to open this against https://github.com/brefphp/aws-lambda-layers

So that the php-fpm process will not hang when reaching log_limit

I'm not sure I understand why the fpm process would hang when reaching log_limit? I understand that the setting will split log lines (bad), but why is anything hanging?

Also have you been able to reproduce the problem and check that this change fixes it?

Thanks!

@allan-simon
Copy link
Contributor Author

allan-simon commented Jun 12, 2024

@mnapoli I will reopen in the other repository , I see that in that one there's clear instruction on how to build the layer so i will be able to test if that actually fix the issue, but looking to the php-src issue I'm pretty confident it does, though I agree with you I'm not sure why it hangs (and I can't reproduce it with the -dev layer )

so I will try to build a custom layer with my patch , deploy it in our test environment in aws

@mnapoli mnapoli closed this Jun 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants