Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

frontend(profile): Add toast messages when user enters incorrect input #372

Closed
wants to merge 1 commit into from

Conversation

didemongu
Copy link

No description provided.

Copy link
Contributor

@okyksl okyksl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@didemongu should we need to create separate functions for each message we're going to make? Why not parametrize each toast and utilize a service for doing this.

@@ -80,4 +83,23 @@ export class PublicPage implements OnInit {
}

}

async presentToastFollow() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@didemongu should we need to create separate functions for each message we're going to make? Why not parametrize each toast and utilize a service for doing this.

@okyksl
Copy link
Contributor

okyksl commented Jan 12, 2019

This is already merged. Checkout #392 for changes I requested.

@okyksl okyksl closed this Jan 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants