Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport doc changes #8542

Merged
merged 2 commits into from
Nov 15, 2024
Merged

Conversation

mrichtarsky
Copy link
Contributor

Includes changes from #8483 #8484

Link to recommended ones

(cherry picked from commit b913d9d)
- Mention zstd as the best general choice when not using lz4
  (as often acknowledged by public benchmarks)
- Mention 'auto' more prominently as a good heuristic to improve
  speed while retaining good compression
- Link to compression options

(cherry picked from commit f656f6b)
Copy link

codecov bot commented Nov 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.83%. Comparing base (2230932) to head (8fe9c5e).
Report is 6 commits behind head on 1.4-maint.

Additional details and impacted files
@@              Coverage Diff              @@
##           1.4-maint    #8542      +/-   ##
=============================================
+ Coverage      82.24%   82.83%   +0.58%     
=============================================
  Files             38       38              
  Lines          11076    11081       +5     
  Branches        2130     1714     -416     
=============================================
+ Hits            9110     9179      +69     
+ Misses          1390     1349      -41     
+ Partials         576      553      -23     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@ThomasWaldmann ThomasWaldmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, will merge after test runs are finished.

Can you please do a backport from this to 1.2-maint branch?

@ThomasWaldmann ThomasWaldmann merged commit 6b4e952 into borgbackup:1.4-maint Nov 15, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants