Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

changes needed for borgstore 0.1.0 #8472

Merged
merged 13 commits into from
Oct 15, 2024
Merged

changes needed for borgstore 0.1.0 #8472

merged 13 commits into from
Oct 15, 2024

Conversation

ThomasWaldmann
Copy link
Member

@ThomasWaldmann ThomasWaldmann commented Oct 14, 2024 •
edited
Loading

  • clean up URLs / URL parsing (esp. how absolute and relative paths work)
  • pre-create store directories

@ThomasWaldmann
require borgstore ~= 0.1.0
7f79b65
@ThomasWaldmann
repo-create: write empty ChunkIndex to repo/cache/, docs
4e576d5
@ThomasWaldmann
new rclone: URLs, fixes borgbackup#8446
83414b0 
rclone:remote:path
@ThomasWaldmann
new sftp: URLs, see borgbackup#8372
d60303e 
sftp://user@host:port/rel/path
sftp://user@host:port//abs/path
@ThomasWaldmann
to_key_filename: generate different filenames for rel/abs paths
72fc028
@ThomasWaldmann
new ssh: URLs, see borgbackup#8372
835b265 
ssh://user@host:port/rel/path
ssh://user@host:port//abs/path

remove the /./ and /~/ hacks.
@ThomasWaldmann
Location: simplify regexes, parsing
858fbae 
There were still some relicts from pre-borgstore / borg 1.x in there:
- patterns about "::", used to be separator between repository and archive.
- patterns for //server/share (not supported by borgstore)

Also: unified ssh+sftp and file+socket processing.
@ThomasWaldmann
update URL docs
6adf18d
@ThomasWaldmann
"file:" Location: use absolute path
ffdc958
@ThomasWaldmann ThomasWaldmann marked this pull request as draft October 14, 2024 23:29
@ThomasWaldmann
create: catch StoreBackendAlreadyExists
703c98d 
Don't show traceback if a repo at the given location already exists.
@ThomasWaldmann ThomasWaldmann marked this pull request as ready for review October 15, 2024 16:08
@codecov Codecov
Copy link

codecov bot commented Oct 15, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 92.85714% with 2 lines in your changes missing coverage. Please review.

Project coverage is 81.76%. Comparing base (2b06ac5) to head (7be254e).
Report is 15 commits behind head on master.

Files with missing lines Patch % Lines
src/borg/repository.py 75.00% 2 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #8472      +/-   ##
==========================================
- Coverage   81.85%   81.76%   -0.09%     
==========================================
  Files          73       73              
  Lines       13124    13110      -14     
  Branches     1934     1926       -8     
==========================================
- Hits        10743    10720      -23     
- Misses       1725     1733       +8     
- Partials      656      657       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ThomasWaldmann ThomasWaldmann merged commit dfbd3b7 into borgbackup:master Oct 15, 2024
15 of 16 checks passed
@ThomasWaldmann ThomasWaldmann deleted the borgstore010 branch October 15, 2024 19:56
This was referenced Oct 15, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ThomasWaldmann