Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Asciidoc doc pages theme switching/footer hiding #1564

Merged
merged 1 commit into from
Dec 23, 2024

Conversation

daveoconnor
Copy link
Collaborator

@julioest julioest requested review from GregKaleka and removed request for gregnewman December 19, 2024 19:49
Copy link
Member

@rbbeeston rbbeeston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm good with this is Greg is

Copy link
Collaborator

@GregKaleka GregKaleka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@julioest
Copy link
Collaborator

🚢 Ship it!

@daveoconnor daveoconnor merged commit baae39d into develop Dec 23, 2024
4 checks passed
@daveoconnor daveoconnor deleted the doc/1547-asciidoctor-dark-mode branch December 23, 2024 18:25
rbbeeston pushed a commit to rbbeeston/website-v2 that referenced this pull request Dec 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants