Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add (partial) implementations for char8_t #192

Merged
merged 14 commits into from
Sep 14, 2023

Conversation

Flamefire
Copy link
Collaborator

This allows usages like

std::string u8ToGbk(const std::u8string &U8Str) {
    return boost::locale::conv::from_utf(U8Str, "GBK");    
}

as found in #190
See also #79

@Flamefire Flamefire force-pushed the utf_chartypes branch 3 times, most recently from 30a53c7 to a5fb543 Compare September 11, 2023 12:28
@codecov
Copy link

codecov bot commented Sep 11, 2023

Codecov Report

Merging #192 (e6b02a4) into develop (0552ffc) will decrease coverage by 0.10%.
The diff coverage is 90.55%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #192      +/-   ##
===========================================
- Coverage    94.69%   94.60%   -0.10%     
===========================================
  Files          113      114       +1     
  Lines         9857     9857              
===========================================
- Hits          9334     9325       -9     
- Misses         523      532       +9     
Files Changed Coverage Δ
include/boost/locale/boundary/boundary_point.hpp 100.00% <ø> (ø)
include/boost/locale/boundary/index.hpp 99.17% <ø> (ø)
include/boost/locale/boundary/segment.hpp 100.00% <ø> (ø)
include/boost/locale/format.hpp 97.81% <ø> (ø)
include/boost/locale/generator.hpp 100.00% <ø> (ø)
include/boost/locale/generic_codecvt.hpp 96.36% <ø> (ø)
include/boost/locale/message.hpp 100.00% <ø> (ø)
include/boost/locale/utf8_codecvt.hpp 100.00% <ø> (ø)
src/boost/locale/encoding/codepage.cpp 97.40% <ø> (ø)
src/boost/locale/icu/formatter.cpp 78.78% <ø> (ø)
... and 33 more

... and 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0552ffc...e6b02a4. Read the comment docs.

Flamefire and others added 4 commits September 12, 2023 10:07
Allows to e.g. convert `std::u8string`s, translate them and run boundary
analysis.
Formatting isn't possible due to lack of facets
(more specifically: their IDs) in the standard libraries
std libraries don't provide the required support
(e.g. missing VTables or facet IDs)
@Flamefire Flamefire merged commit e0b28bf into boostorg:develop Sep 14, 2023
@Flamefire Flamefire deleted the utf_chartypes branch September 14, 2023 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant