Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Credentials provided by extension need to override credentials in store #1196

Merged
merged 1 commit into from
Oct 2, 2023
Merged

Credentials provided by extension need to override credentials in store #1196

merged 1 commit into from
Oct 2, 2023

Conversation

tkrah
Copy link
Contributor

@tkrah tkrah commented Sep 28, 2023 •
edited
Loading

Test added.

@bmuschko bmuschko added the bug label Oct 2, 2023
bmuschko
bmuschko approved these changes Oct 2, 2023
View reviewed changes
Copy link
Owner

@bmuschko bmuschko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bmuschko bmuschko changed the title Fixes regression #1179 Credentials provided by extension need to override credentials in store Oct 2, 2023
@bmuschko bmuschko added this to the v9.3.4 milestone Oct 2, 2023
@bmuschko bmuschko merged commit eb63885 into bmuschko:master Oct 2, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bmuschko bmuschko bmuschko approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
v9.3.4
Development

Successfully merging this pull request may close these issues.
2 participants
@tkrah @bmuschko