add: compose, readme, and dockerfile for qt gui #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@padraic-shafer You can expect all tests to fail in the GHA. It is on the TODOs to fix up this test suite following the same paradigm as the containers used in local testing. |
docker/README.md
Outdated
| cd ../ | ||
| export LOCAL_DISPLAY_IP=$(ifconfig en0 | grep inet | awk '$1=="inet" {print $2}') |
There was a problem hiding this comment.
Consider handing either Linux or MacOS here
Suggested change
| export LOCAL_DISPLAY_IP=$(ifconfig en0 | grep inet | awk '$1=="inet" {print $2}') | |
| export LOCAL_DISPLAY_IP=$([[ ! -z "${DISPLAY}" ]] && echo "${DISPLAY}" || ifconfig en0 | grep inet | awk '$1=="inet" {print $2":0"}') |
There was a problem hiding this comment.
This took a bit more wrangling because OSX has a DISPLAY variable that is not the IP needed for X11 forwarding from the container. So I broke this into a bash script that checks for Darwin, etc and operates accordingly.
Co-authored-by: Padraic Shafer <[email protected]>
- add: bash file to set local display conditionally on mac/linux - Move entrypoint command to CMD - Update README
|
@padraic-shafer I made some updates in 8aa1cc2 to fix the security issue of xhost and be more deliberate with the DISPLAY variables between Mac/linux. Take another look when you get a chance! |
padraic-shafer
approved these changes
Jan 11, 2024
Co-authored-by: Padraic Shafer <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the qtgui for the Queue Server from Bluesky widgets as an independent container.
Description
Adds the image, docker compose, updated readme directions. Depends on jozo/pyqt5.
Motivation and Context
People wanted better documentation around the gui, and having a quick container to spin up and test is the first step there. This should also facilitate better local testing.
Summary of Changes for Release Notes
Add container for Bluesky Widgets QTGui (queue-monitor) for Bluesky Adaptive
Added
Changed
How Has This Been Tested?
Tested on a Mac which should be the hardest way to do this.