-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add functionality for pausing/stoping/aborting per event #29
feat: add functionality for pausing/stoping/aborting per event #29
Conversation
- Adds tests - Adds RecommendPause as subclass of RunEngineControlException - doc/refactor: removes gp assumptions from syntax
@@ -81,6 +82,9 @@ def callback(name, doc): | |||
except NoRecommendation: | |||
# no recommendation | |||
queue.put(None) | |||
except RunEngineControlException as e: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Handle the except Exepction
case here as well so that it get re-raised correctly in L173 rather than being raised in which ever stack this callback is running in.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added generic exception pass through to plan here 8b70052
I'm going to merge over the failures as it looks like they are due to changes in other bluesky libraries. |
|
GHA Tests and Docs are on my next todos. |
In response to this Mattermost issue, adds the ability for an adaptive eventwise plan to pause, stop, or abort.
Description
RequestPause
as subclass of RunEngineControlExceptionRequestStop
,RequestAbort
)RequestPause
error toyield from bps.pause()
Motivation and Context
This may be overkill for the issue @untzag had, but it is a broadly applicable need.
Summary of Changes for Release Notes
Add per-event adaptive functionality to handle stopping/aborting/pausing the RunEngine
Fixed
Added
Adds
RequestPause
as subclass of RunEngineControlExceptionChanged
RequestStop
,RequestAbort
)RequestPause
error toyield from bps.pause()
Removed
How Has This Been Tested?
Additional unit tests. Expect CI/CD via GHA to still fail, but these tests pass locally.