Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: make ExtBytecode pointer private #1904

Merged
merged 1 commit into from
Dec 9, 2024
Merged

Conversation

rakita
Copy link
Member

@rakita rakita commented Dec 9, 2024

close #1902

Copy link
Contributor

github-actions bot commented Dec 9, 2024

Valgrind Results:

==4481== Cachegrind, a cache and branch-prediction profiler
==4481== Copyright (C) 2002-2017, and GNU GPL'd, by Nicholas Nethercote et al.
==4481== Using Valgrind-3.18.1 and LibVEX; rerun with -h for copyright info
==4481== Command: target/release/revme bench snailtracer
==4481== 
--4481-- warning: L3 cache found, using its data for the LL simulation.
Running snailtracer example!
elapsed: 1.936055099s
==4481== 
==4481== I   refs:      462,304,056
==4481== I1  misses:          7,199
==4481== LLi misses:          4,062
==4481== I1  miss rate:        0.00%
==4481== LLi miss rate:        0.00%
==4481== 
==4481== D   refs:      213,298,506  (135,374,143 rd   + 77,924,363 wr)
==4481== D1  misses:        340,895  (    201,232 rd   +    139,663 wr)
==4481== LLd misses:        136,164  (      3,914 rd   +    132,250 wr)
==4481== D1  miss rate:         0.2% (        0.1%     +        0.2%  )
==4481== LLd miss rate:         0.1% (        0.0%     +        0.2%  )
==4481== 
==4481== LL refs:           348,094  (    208,431 rd   +    139,663 wr)
==4481== LL misses:         140,226  (      7,976 rd   +    132,250 wr)
==4481== LL miss rate:          0.0% (        0.0%     +        0.2%  )

@rakita rakita merged commit dff83c6 into main Dec 9, 2024
26 of 27 checks passed
@rakita rakita deleted the rakita/extb_private_pointer branch December 9, 2024 11:42
royvardhan pushed a commit to royvardhan/revm that referenced this pull request Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Maybe unsound in ExtBytecode
1 participant