Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: refactor
L1BlockInfo::tx_estimated_size_fjord
#1856chore: refactor
L1BlockInfo::tx_estimated_size_fjord
#1856Changes from all commits
d75c02e
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we change this to u64?
looks like we use this in other places where we can also operate on u64
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The call in
calculate_tx_l1_cost_fjord
multiples with a largel1_fee_scaled
soU256
is needed.The call in
data_gas
looks pretty safe, but is not in any hot path asdata_gas
is only called incalculate_tx_l1_cost_bedrock
andcalculate_tx_l1_cost_ecotone
that don't pass in aFJORD
-enabled spec.I'd say it's not worth it as it forces callers to mentally track
u64::MAX
to not wrap in aU256
anyway. It's easier withintx_estimated_size_fjord
as we know even au32::MAX
returned byflz_compress_len
wouldn't overflowu64
.