Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: eip-7623 #1744

Merged
merged 3 commits into from
Dec 6, 2024
Merged

feat: eip-7623 #1744

merged 3 commits into from
Dec 6, 2024

Conversation

rkrasiuk
Copy link
Collaborator

@rkrasiuk rkrasiuk commented Sep 3, 2024

Description

Implementation of EIP-7623.
Reference spec PR: ethereum/execution-specs#966.

Pending clarification and final inclusion in the fork

Copy link
Contributor

github-actions bot commented Sep 3, 2024

Valgrind Results:

==3953== Cachegrind, a cache and branch-prediction profiler
==3953== Copyright (C) 2002-2017, and GNU GPL'd, by Nicholas Nethercote et al.
==3953== Using Valgrind-3.18.1 and LibVEX; rerun with -h for copyright info
==3953== Command: target/release/snailtracer
==3953== 
--3953-- warning: L3 cache found, using its data for the LL simulation.
Running snailtracer example!
elapsed: 1.83093677s
==3953== 
==3953== I   refs:      427,436,875
==3953== I1  misses:          3,152
==3953== LLi misses:          2,850
==3953== I1  miss rate:        0.00%
==3953== LLi miss rate:        0.00%
==3953== 
==3953== D   refs:      203,986,108  (132,175,448 rd   + 71,810,660 wr)
==3953== D1  misses:        342,749  (    202,812 rd   +    139,937 wr)
==3953== LLd misses:        137,711  (      4,396 rd   +    133,315 wr)
==3953== D1  miss rate:         0.2% (        0.2%     +        0.2%  )
==3953== LLd miss rate:         0.1% (        0.0%     +        0.2%  )
==3953== 
==3953== LL refs:           345,901  (    205,964 rd   +    139,937 wr)
==3953== LL misses:         140,561  (      7,246 rd   +    133,315 wr)
==3953== LL miss rate:          0.0% (        0.0%     +        0.2%  )

@rakita rakita changed the base branch from main to release/v51 December 6, 2024 16:27
@rakita rakita marked this pull request as ready for review December 6, 2024 16:31
Copy link
Member

@rakita rakita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, we will figure out tests later.

Made a small refactor and added InitialAndFloorGas

@rakita rakita merged commit 6882e22 into release/v51 Dec 6, 2024
18 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants