This repository has been archived by the owner on Mar 7, 2023. It is now read-only.
New mdid #368
Open
New mdid #368
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # karma.conf.js # package.json # src/blockchain-wallet.js
|
368 |
sat666alex
approved these changes
May 21, 2017
# Conflicts: # package.json # src/index.js
sha49
commented
Aug 1, 2017
src/contact.js
Outdated
| @@ -14,6 +14,7 @@ class Contact { | |||
| this.id = o.id; | |||
| this.mdid = o.mdid; | |||
| this.name = o.name; | |||
| this.senderName = o.senderName; | |||
There was a problem hiding this comment.
Do we really need that? I think android is just asking for the name you want to share every time you invite somebody. The less extra information we have on the facilitated tx list the better. Actually, if you want to save somewhere your own name you should not do it on the TX, it might be a settings of contacts or your application
There was a problem hiding this comment.
Ok I will just do what Android does. I will also remove initiator_source since mobile teams also decided to not use that.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
contacts branch used by iOS