Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding in desktop hints #521

Open
wants to merge 2 commits into
base: v1.0
Choose a base branch
from
Open

adding in desktop hints #521

wants to merge 2 commits into from

Conversation

michaelneale
Copy link
Collaborator

trying out a system to add desktop relevant hints

@michaelneale michaelneale requested a review from Copilot December 23, 2024 04:32
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

Comments suppressed due to low confidence (3)

crates/goose/src/systems/os_hints.rs:106

  • [nitpick] The error message 'Windows detection not yet implemented' is unclear. Consider providing more context or instructions.
hints.push("Windows detection not yet implemented".to_string());

crates/goose/src/systems/os_hints.rs:99

  • The function 'detect_linux_tools' is not covered by tests. Add tests to ensure its functionality.
fn detect_linux_tools(hints: &mut Vec<String>) {

crates/goose/src/systems/os_hints.rs:104

  • The function 'detect_windows_tools' is not covered by tests. Add tests to ensure its functionality.
fn detect_windows_tools(hints: &mut Vec<String>) {

crates/goose/src/systems/os_hints.rs Outdated Show resolved Hide resolved
Copy link

Desktop App for this PR

The following build is available for testing:

The app is signed and notarized for macOS. After downloading, unzip the file and drag the Goose.app to your Applications folder.

This link is provided by nightly.link and will work even if you're not logged into GitHub.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant