feat [cli]: Add keyring management for OpenAI API keys #361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kvadratni
reviewed
Nov 27, 2024
updated! |
baxen
approved these changes
Nov 28, 2024
jsibbison-square
added a commit
that referenced
this pull request
Nov 28, 2024
* v1.0: feat: Hardened runtime and notarization (#367) feat: use mac main menu (#366) [app] Turn send button into stop button when goose is responding so user can cancel if needed [app] Fix position for MoreMenu and make top region a little smaller feat [cli]: Add keyring management for OpenAI API keys (#361)
michaelneale
added a commit
that referenced
this pull request
Nov 28, 2024
* v1.0: fix: During configure remove 'recommended' from provider descriptions (#372) [cli] On interrupt repair messages (#370) feat: add low priority user output for bash feat: collapse long tool args (#368) feat: Hardened runtime and notarization (#367) feat: use mac main menu (#366) [app] Turn send button into stop button when goose is responding so user can cancel if needed [app] Fix position for MoreMenu and make top region a little smaller feat [cli]: Add keyring management for OpenAI API keys (#361) Interrupt running shell tool commands (#365) [GUI multiprocess] tabless multiple goosed processes per window (#355) feat: simplify initial session splash (#362) fix: hide response form behind flag
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove API key handling from client for OpenAI provider. Instead, core goose will check the keyring, then the env variable for the API key and finally ask the user to input it if in neither of those locations, after which it will be set in the environment.