Refactor gemspecs to no longer use gemspec_helper.rb.
#78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
myronmarston
force-pushed
the
myron/dependabot-fixes/step4
branch
from
8d3b7c1 to
2f9c556
Compare
Instead, inline the full definition of the gemspec in each `.gemspec` file. This should fix a dependabot error we are getting: ``` Bundler::GemspecError with message: [!] There was an error while loading `elasticgraph.gemspec`: uninitialized constant ElasticGraphGemspecHelper. Bundler cannot continue. # from /home/dependabot/dependabot-updater/repo/elasticgraph/elasticgraph/elasticgraph.gemspec:14 # ------------------------------------------- # > ElasticGraphGemspecHelper.define_elasticgraph_gem(gemspec_file: __FILE__, category: :core) do |spec, eg_version| # spec.summary = "ElasticGraph meta-gem that pulls in all the core ElasticGraph gems." # ------------------------------------------- ```
myronmarston
force-pushed
the
myron/dependabot-fixes/step4
branch
from
2f9c556 to
db71460
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead, inline the full definition of the gemspec in each
.gemspecfile. This should fix a dependabot error we are getting: