Skip to content

Commit

Permalink
Fix CODEOWNERS so that @BrianSigafoos-SQ and I are both owners.
Browse files Browse the repository at this point in the history
I thought it was a markdown list but it turns out the `*` is a wildcard
and all owners have to be listed on the same line, as per the docs[^1]:

> If you want to match two or more code owners with the same pattern,
> all the code owners must be on the same line. If the code owners are
> not on the same line, the pattern matches only the last mentioned
> code owner.

[^1]: https://docs.github.com/en/repositories/managing-your-repositorys-settings-and-features/customizing-your-repository/about-code-owners#codeowners-syntax
  • Loading branch information
myronmarston committed Oct 31, 2024
1 parent 0e5352a commit 008fd61
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions .github/CODEOWNERS
Validating CODEOWNERS rules …
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,7 @@
# The format is described: https://github.blog/2017-07-06-introducing-code-owners/

# These owners will be the default owners for everything in the repo.
* @myronmarston
* @BrianSigafoos-SQ
* @myronmarston @BrianSigafoos-SQ

# -----------------------------------------------
# BELOW THIS LINE ARE TEMPLATES, UNUSED
Expand Down

0 comments on commit 008fd61

Please sign in to comment.