Add a retry mechanism for recording ready notifier #1129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ithanil
approved these changes
Dec 5, 2024
There was a problem hiding this comment.
LGTM
I mean, this kind of brute forcing is not the prettiest solution, but doing it "properly" would be considerably more effort.
I have also successfully tested the changes in actual deployment with a Scalelite and a (correspondingly patched) Greenlight, where one of LOADBALANCER_SECRETS is used for the GL.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1029
Description
Add a "retry" mechanism to loop through all of the loadbalancer secrets when sending the recording ready notification service
Greenlight PR: bigbluebutton/greenlight#5972
Testing Steps
Screenshots (if appropriate):