Apply meta_server-tag from default/override create parameters early in create #1066
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…the create call, to actually achieve the effect on server selection
…nce of defaults/override as in add_additional_params
farhatahmad
force-pushed
the
master
branch
2 times, most recently
from
a64bbb9 to
4a57c23
Compare
farhatahmad
reviewed
Jun 28, 2024
|
@farhatahmad Please let me test this again after I made your suggested change, just to be sure. |
…g overrides/defaults
Ithanil
force-pushed
the
handle_tenant_server-tag
branch
from
53d1495 to
9c622d0
Compare
|
After changing the assignment operator from ||= to = the code with your suggested change appears to be fine. With ||= the right hand side will not be evaluated and assigned if the left hand side is a truthy value. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds early handling of any meta_server-tag parameter found in DEFAULT_CREATE_PARAMS /OVERRIDE_CREATE_PARAMS or the respective tenantSettings to the create call procedure. This is necessary to ensure the parameter has the desired effect on server selection, which occurs way before the passed create parameters are merged with configured parameters usually.
In the later occurring merging of parameters, the meta_server-tag is then excluded, to maintain the fact that the final meta_server-tag parameter is always equal to the chosen server's tag.
This PR is required to make my suggestion in #1053 actually work.
Testing Steps
Tested combinations of passed vs. configured meta_server-tag via API Mate.
Other notes
At a first glance, e.g. meta_lrs parameters would also require this treatment. I wonder if it would be better to handle all meta parameters early.