Remove '.sh' from scalelite_prune_recordings such that it actually gets executed by cron #1055
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ts executed by cron + added short README section
farhatahmad
approved these changes
Apr 2, 2024
|
Thanks @Ithanil - much appreciated. |
farhatahmad
pushed a commit
that referenced
this pull request
Jun 27, 2024
…ts executed by cron + added short README section (#1055)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Having a dot in a filename prevents execution by cron when put under /etc/cron directories. Therefore, this PR removes the
.shextension from the filename. Also, a short README section is added.See #1044 for further details regarding the cron behavior.
Fixed issues
#1044
Note
This will break any automated build scripts relying on the old filename to download the script from the repo. However, I assume in many cases they didn't rename the file and thus the script didn't do anything anyway.