Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add blazium services as submodule #209

Merged

Conversation

Ughuuu
Copy link

@Ughuuu Ughuuu commented Dec 25, 2024

No description provided.

@Ughuuu Ughuuu marked this pull request as ready for review December 26, 2024 14:46
jss2a98aj
jss2a98aj previously approved these changes Dec 26, 2024
Copy link
Member

@jss2a98aj jss2a98aj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we want the SDK to be included in build artifacts produced by actions, we will need to init submodules. Doing so near the start of the static checks action would probably do it.
The last three commits could have been one, but the first one does need to be separate due to the submodule using the same folder as the removed files.
Edit: If we use git submodule init without a specific submodule specificed, it will handle all future submodules as well.

@Ughuuu Ughuuu force-pushed the add-blazium-services-as-submodule branch 2 times, most recently from 350fe10 to 8b7dec1 Compare December 28, 2024 12:59
Bioblaze
Bioblaze previously approved these changes Dec 28, 2024
@Ughuuu Ughuuu force-pushed the add-blazium-services-as-submodule branch 2 times, most recently from bba92e2 to b2ddcae Compare December 29, 2024 15:03
@Ughuuu Ughuuu requested review from jss2a98aj and Bioblaze December 29, 2024 23:02
Bioblaze
Bioblaze previously approved these changes Dec 29, 2024
Update blazium_sdk

Update blazium_sdk

update branch to 4.3

Update blazium_sdk

update

update

add submodule recursive
@Ughuuu Ughuuu force-pushed the add-blazium-services-as-submodule branch from f39d663 to 385b738 Compare December 30, 2024 09:24
@Bioblaze Bioblaze merged commit 9905108 into blazium-engine:blazium-dev Dec 30, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants