Updated the cache_get method to use the with block #2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cclauss
reviewed
Nov 24, 2024
cclauss
reviewed
Nov 24, 2024
| else: | ||
| log.debug(f'Cached content for "{key}" is older than {cache_hrs:,} hours') | ||
|
|
||
| return None |
There was a problem hiding this comment.
|
Can we merge this? |
|
Merge it with failing tests? |
|
What am I missing after making changes? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR ,
To properly handle file operations and ensure that the file is closed after it's no longer needed, you can use a with block. I have updated code that automatically handle closing the file when the block of code is finished, preventing resource leaks.