Don't encode invalid programs as valid unrelated programs #2231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not sure if this is the right fix, but I noticed the GL renderer turning bgfx::touch() into actual rendering calls using geometry from another draw call. |
added 2 commits
September 30, 2020 23:23
When an invalid program is submitted with bgfx::touch(), it gets encoded as program index 0 by the command encoder. Since program 0 can be a valid program (typically it's the debug text blitter program), this can result in garbage being drawn if no other rendering is submitted for the same view. This patch changes invalid programs to be encoded as invalid programs, so the renderer can properly ignore them.
When an invalid program handle is encoded (e.g., with handle 0xffff), it will overflow the space reserved for program handles in the sorting key. This patch fixes the issue by turning any out-of-range program handles back to invalid handles when decoding sorting keys.
|
I noticed that even with my earlier fix the decoder doesn't recognize invalid programs correctly, so I made a follow-up. Does this seem right, or am I missing something about how bgfx::touch() works? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When an invalid program is submitted with bgfx::touch(), it gets encoded
as program index 0 by the command encoder. Since program 0 can be a
valid program (typically it's the debug text blitter program), this can
result in garbage being drawn by the renderer.
This patch changes invalid programs to be encoded as invalid programs,
so the renderer can properly ignore them.